Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thermo-nuclear code-quality review (Oracle-coordinated read-only swarm) Verdict: PASS for merge readiness; no merge-blocking thermo finding. The reserve alias handling remains at the existing cost-pricing normalization boundary, with focused normalization and pricing-equivalence tests. The diff is small, scoped, and introduces no large-file, wrapper, orchestration, type-boundary, or decomposition regression. The dependent stack remains blocked only by the inherited parser-routing issue recorded on PR #489. |
|
Thermo follow-up: final dependency receipt. Oracle's final thermo adjudication passes #490's own reserve-pricing normalization. No #490 code change was required; its stacked base now includes the repaired #488 parser commit Oracle post-fix verdict: PASS. Merge after #489 and after a fresh hosted-check read-back. |
06d4955
into
port/micro-0.57.0-opencodex-numeric
What this ports
Ports upstream commit
57ddfdbf70f2de23c1b5bd8fdb3c660944a22b4afromsteipete/CodexBarfor the reserve telemetry pricing alias.The local Rust equivalent normalizes the exact
gpt-reservealias togpt-5.6-luna, including trimmed, provider-qualified, and case-insensitive input forms. The shared normalizer is used by both fresh usage and cached pricing paths.Scope
Changed files:
rust/src/core/cost_pricing.rsrust/src/core/cost_pricing_tests.rsThe port intentionally excludes upstream Swift generated pricing, parser/cache, UI, documentation, and changelog surfaces that do not map to this local Rust implementation.
This PR is stacked after the numeric parsing lane in PR #489:
port/micro-0.57.0-opencodex-numericport/micro-0.57.0-reserve-pricingValidation
cargo fmt --all -- --check— passedgit diff --check— passedcore::cost_pricing::tests::gpt_reserve_alias_uses_luna_pricinglink.exeto Gitusr/bin/link.exe, which rejected MSVC linker arguments withlink: extra operand.Oracle reviewed the implementation and approved staging, commit, push, and this stacked PR. The PR remains open for review; no merge is requested by this porting step.